Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42 cohort methods test #47

Merged
merged 5 commits into from
Jan 9, 2025
Merged

42 cohort methods test #47

merged 5 commits into from
Jan 9, 2025

Conversation

syroBx
Copy link
Collaborator

@syroBx syroBx commented Dec 19, 2024

Cover steps test for #42

  • steps_range
  • eval_step_filters
  • next_step

@syroBx syroBx self-assigned this Dec 19, 2024
@syroBx syroBx closed this Dec 19, 2024
@syroBx syroBx reopened this Dec 19, 2024
Copy link
Member

@galachad galachad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments from me, please take a look.

tests/testthat/test-cohort_methods.R Outdated Show resolved Hide resolved
tests/testthat/test-cohort_methods.R Outdated Show resolved Hide resolved
tests/testthat/test-reproducible_code_utils.R Outdated Show resolved Hide resolved
@syroBx syroBx requested a review from galachad January 7, 2025 12:45
Copy link
Member

@galachad galachad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galachad galachad merged commit 144eab6 into dev Jan 9, 2025
@galachad galachad deleted the 42-cohort_methods_test branch January 9, 2025 10:21
@syroBx syroBx restored the 42-cohort_methods_test branch January 14, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants